linux-kernel - Re: [PATCH v2] hpsa: fix a memory leak in hpsa_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f29e2dbc-9a37-4e45-9d4b-c52526b7d0c5@web.de>
Date: Sat, 10 Jan 2026 07:55:14 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>, linux-scsi@...r.kernel.org,
 storagedev@...rochip.com, Don Brace <don.brace@...rochip.com>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] hpsa: fix a memory leak in hpsa_find_cfgtables()

> If write_driver_ver_to_cfgtable() fails, add iounmap() to
> release the memory allocated by remap_pci_mem().

How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc4#n526

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n659

> Found by manual static code review.

Can such information indicate a contradiction?

Regards,
Markus