linux-kernel - Re: [GIT PULL] erofs fix for 6.19-rc5 (fix the stupid mistake)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxht2EWvryy9bZw6uRsCyAc6WCHHvAjP=X92x9Pk9CaM0g@mail.gmail.com>
Date: Sat, 10 Jan 2026 10:50:41 +0100
From: Amir Goldstein <amir73il@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>, linux-erofs@...ts.ozlabs.org, 
	LKML <linux-kernel@...r.kernel.org>, Amir Goldstein <amir73il@...il.com>, 
	Alexander Larsson <alexl@...hat.com>, Dusty Mabe <dusty@...tymabe.com>, Chao Yu <chao@...nel.org>, 
	Sheng Yong <shengyong1@...omi.com>, Zhiguo Niu <zhiguo.niu@...soc.com>, 
	Christian Brauner <brauner@...nel.org>, Miklos Szeredi <mszeredi@...hat.com>, Gao Xiang <xiang@...nel.org>
Subject: Re: [GIT PULL] erofs fix for 6.19-rc5 (fix the stupid mistake)

On Sat, Jan 10, 2026 at 8:27 AM Gao Xiang <xiang@...nel.org> wrote:
>
> Hi Linus,
>
> Very sorry I sent an incorrect pull request which used an
> outdated PATCH version (I just manually applied tags on the
> incorrect version, but I didn't realize), I shouldn't make
> the stupid mistake in the beginning.
>
> Someone reminded me the mistake just now.
>
> Could you please apply this pull request, I promise that I
> won't make the similar fault again and I should be blamed.
>
> Thanks,
> Gao Xiang
>
> The following changes since commit 072a7c7cdbea4f91df854ee2bb216256cd619f2a:
>
>   erofs: don't bother with s_stack_depth increasing for now (2026-01-10 13:01:15 +0800)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git tags/erofs-for-6.19-rc5-fixes-2
>
> for you to fetch changes up to 0a7468a8de7a2721cc0cce30836726f2a3ac2120:
>
>   erofs: don't bother with s_stack_depth increasing for now [real fix] (2026-01-10 15:13:12 +0800)
>
> ----------------------------------------------------------------
> Changes since last update:
>
>  - Revert the incorrect outdated PATCH version
>
>  - Apply the correct fix of
>    "erofs: don't bother with s_stack_depth increasing for now"
>
> ----------------------------------------------------------------
> Gao Xiang (2):
>       Revert "erofs: don't bother with s_stack_depth increasing for now"
>       erofs: don't bother with s_stack_depth increasing for now [real fix]
>

Gao,

You merged the wrong patch version by mistake - no real harm done.

But now that it was merged, for the sake of git history, I think it would
be better to merge a fix patch rather than revert + patch with same title.

If you merge a fix patch you could properly attribute Report/Review/Tested-by
to Sheng Yong [1].

It's true that the merged patch already claims to work for Android APEX,
but it had a braino bug and this is what fix patches are for.

Thanks,
Amir.

[1] https://lore.kernel.org/linux-fsdevel/243f57b8-246f-47e7-9fb1-27a771e8e9e8@gmail.com/