linux-kernel - Re: [PATCH] iommu/riscv: Fix unsigned comparison with negative error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mrufqpwz3sfpren7lqfukyqw3bnjhpvgo7huxhx7fbdwt3j3pn@mfv6ptky2kgt>
Date: Sat, 10 Jan 2026 11:15:23 +0100
From: Joerg Roedel <joro@...tes.org>
To: Alper Ak <alperyasinak1@...il.com>
Cc: tjeznach@...osinc.com, Dan Carpenter <error27@...il.com>, 
	Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>, 
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, iommu@...ts.linux.dev, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/riscv: Fix unsigned comparison with negative error
 code

On Mon, Dec 22, 2025 at 06:15:49PM +0300, Alper Ak wrote:
> -	iommu->irqs_count = platform_irq_count(pdev);
> -	if (iommu->irqs_count <= 0)
> +	ret = platform_irq_count(pdev);
> +	if (ret < 0)
> +		return ret;
> +
> +	iommu->irqs_count = ret;
> +
> +	if (!iommu->irqs_count)
>  		return dev_err_probe(dev, -ENODEV,
>  				     "no IRQ resources provided\n");

Separate the ret < 0 and ret == 0 checks is wrong, just check them in one if
statement and return the dev_err_probe() value as before.

-Joerg