linux-kernel - Re: [PATCH v14 01/10] iomap: stash iomap read ctx in the private field of iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3e1f6e5-c4ac-4913-a41b-20edbc1d7a46@linux.alibaba.com>
Date: Sat, 10 Jan 2026 19:55:12 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: chao@...nel.org, brauner@...nel.org, amir73il@...il.com, hch@....de,
 linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, Hongbo Li <lihongbo22@...wei.com>
Subject: Re: [PATCH v14 01/10] iomap: stash iomap read ctx in the private
 field of iomap_iter

Hi Darrick,

On 2026/1/10 02:14, Darrick J. Wong wrote:
> On Fri, Jan 09, 2026 at 10:28:47AM +0000, Hongbo Li wrote:
>> It's useful to get filesystem-specific information using the
>> existing private field in the @iomap_iter passed to iomap_{begin,end}
>> for advanced usage for iomap buffered reads, which is much like the
>> current iomap DIO.
>>
>> For example, EROFS needs it to:
>>
>>   - implement an efficient page cache sharing feature, since iomap
>>     needs to apply to anon inode page cache but we'd like to get the
>>     backing inode/fs instead, so filesystem-specific private data is
>>     needed to keep such information;
>>
>>   - pass in both struct page * and void * for inline data to avoid
>>     kmap_to_page() usage (which is bogus).
>>
>> Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
>> Reviewed-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
> 
> This looks like a dead simple patch to allow iomap pagecache users to
> set iomap_iter::private, so no objections here:
> 
> Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

Thanks for the review!

Thanks,
Gao Xiang

> 
> --D
>