linux-kernel - Re: [PATCH v3] wifi: iwlegacy: 3945-rs: add a defensive WARN_ON_ONCE for il_sta in il3945_rs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADm8Te=SCAW0gP3QTwb5vtDNhbqqwEFUKNkwgAvBkA6vqVQw7A@mail.gmail.com>
Date: Sat, 10 Jan 2026 21:49:04 +0800
From: Tuo Li <islituo@...il.com>
To: Stanislaw Gruszka <stf_xl@...pl>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] wifi: iwlegacy: 3945-rs: add a defensive WARN_ON_ONCE
 for il_sta in il3945_rs_get_rate()

Hi Stanislaw,

On Sat, Jan 10, 2026 at 4:42 AM Stanislaw Gruszka <stf_xl@...pl> wrote:
>
> Hi
>
> On Fri, Jan 09, 2026 at 11:12:55PM +0800, Tuo Li wrote:
> > > Sorry for giving you wrong advice before, but after examining related code
> > > I agree with Johannes the il_sta can not be NULL.
> > > Now, I think we should just remove il_sta/rs_sta pointer check.
> > >
> > > Regards
> > > Stanislaw
> >
> > Thanks for the follow-up and your patience. I appreciate you taking
> > another look at the code.
> >
> > Just to confirm, would you like me to submit a v4 patch that removes the
> > unnecessary il_sta / rs_sta checks, e.g.:
> >
> > in il3945_rs_get_rate():
> >
> > - if (rs_sta && !rs_sta->il) {
> > + if (!rs_sta->il) {
> >
> > and in il3945_rs_tx_status():
> >
> > - if (!il_sta) {
> > -     D_RATE("leave: No STA il data to update!\n");
> > -     return;
> > - }
>
> Yes, please post those changes as v4.
>
> Thanks
> Stanislaw

Thanks for your reply.

I will post these changes and submit a v4 patch shortly.

Best regards,
Tuo