linux-kernel - Re: [PATCH] iommu/amd: move wait_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34214ff1-3aed-4d6c-8ea6-379341bb0c29@web.de>
Date: Sat, 10 Jan 2026 15:00:16 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Ankit Soni <Ankit.Soni@....com>, iommu@...ts.linux.dev,
 Jörg Rödel <joro@...tes.org>,
 Robin Murphy <robin.murphy@....com>,
 Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
 Vasant Hegde <vasant.hegde@....com>, Will Deacon <will@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu/amd: move wait_on_sem() out of spinlock

…
> +++ b/drivers/iommu/amd/iommu.c
…
> @@ -3094,13 +3098,18 @@ static void iommu_flush_irt_and_complete(struct amd_iommu *iommu, u16 devid)
…
> +out_err:
>  	raw_spin_unlock_irqrestore(&iommu->lock, flags);
> +	return;
>  }
…

How do you think about to omit a return statement at the end of the implementation
of such a function with the type “void”?

See also:
https://elixir.bootlin.com/linux/v6.19-rc4/source/scripts/checkpatch.pl#L5612-L5622

Regards,
Markus