linux-kernel - Re: [PATCH] lib/tests: add KUnit test for bitops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHMDPKV4MR8WF29+0VxocxYWAZxhvrANU-VE__LzQef-UnzW2g@mail.gmail.com>
Date: Sat, 10 Jan 2026 23:19:47 +0900
From: Ryota Sakamoto <sakamo.ryota@...il.com>
To: Yury Norov <ynorov@...dia.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Yury Norov <yury.norov@...il.com>, 
	Rasmus Villemoes <linux@...musvillemoes.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/tests: add KUnit test for bitops

Hi Yury,

Thank you for your warm welcome and detailed review.

On Sat, Jan 10, 2026 at 11:25 AM Yury Norov <ynorov@...dia.com> wrote:
> I'm not a user of kunit, but some people are. And seemingly it would help
> to improve testing coverage through those enabling KUNIT_ALL_TESTS. So I
> don't object against this test.

I'm glad you agree. As you noted, while it is based on the logic from
lib/test_bitops.c, it adapts the test to KUnit framework and fixes the coverage
gap in find_first_bit().

> Can you please resend this patch, and in commit message list all the
> tests from the original lib/test_bitops? Please mention those you move
> to the new test. Is there any new coverage in your version?
>
> Please attach whatever it prints as an output, if any.

Sure, in v2, I will include the list for ported test cases and include
the execution output.

> It's tested at boot only if 'y'. If 'm' - it's not.
> Those 2 paragraphs don't relate to the new test, don't even mention
> it. Please drop them.
> I would add a note that this is a partial copy of test_bitops, and in case
> of _any_ doubt, one could enable config TEST_BITOPS and run the original
> test.

You are right. I will remove the generic KUnit description and add
a reference to the original test.

> Those gentlemen are not even in CC. Are you sure they agree to
> be in this list?

I kept their names to credit the original authors from lib/test_bitops.c. I will
include them in CC for v2.

Regards,
Ryota Sakamoto