linux-kernel - [PATCH] btrfs: fail metadata async reclaim early if filesystem is aborted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260110200729.9590-1-jiashengjiangcool@gmail.com>
Date: Sat, 10 Jan 2026 20:07:29 +0000
From: Jiasheng Jiang <jiashengjiangcool@...il.com>
To: Chris Mason <clm@...com>,
	David Sterba <dsterba@...e.com>
Cc: linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: [PATCH] btrfs: fail metadata async reclaim early if filesystem is aborted

Currently, do_async_reclaim_metadata_space cycles through all flush
states even if the filesystem has been aborted. In contrast, the data
reclaim path (do_async_reclaim_data_space) explicitly checks for
BTRFS_FS_ERROR and fails all pending tickets immediately.

This inconsistency causes the metadata reclaimer to waste CPU cycles
performing useless flush operations (like attempting to commit a
transaction or allocate chunks) on a broken filesystem.

Fix this by adding a BTRFS_FS_ERROR check inside the metadata reclaim
loop, ensuring that we fail all tickets and exit as soon as a
filesystem error is detected, matching the behavior of data reclaim.

Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
---
 fs/btrfs/space-info.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
index 6babbe333741..b3aae44a1436 100644
--- a/fs/btrfs/space-info.c
+++ b/fs/btrfs/space-info.c
@@ -1189,6 +1189,14 @@ static void do_async_reclaim_metadata_space(struct btrfs_space_info *space_info)
 			spin_unlock(&space_info->lock);
 			return;
 		}
+
+		if (unlikely(BTRFS_FS_ERROR(fs_info))) {
+			maybe_fail_all_tickets(space_info);
+			space_info->flush = false;
+			spin_unlock(&space_info->lock);
+			return;
+		}
+
 		to_reclaim = btrfs_calc_reclaim_metadata_size(space_info);
 		if (last_tickets_id == space_info->tickets_id) {
 			flush_state++;
-- 
2.25.1