linux-kernel - Re: [PATCH v11 02/12] vduse: add vq group support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260110183910-mutt-send-email-mst@kernel.org>
Date: Sat, 10 Jan 2026 18:44:41 -0500
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Eugenio Pérez <eperezma@...hat.com>
Cc: linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
	Maxime Coquelin <mcoqueli@...hat.com>,
	Laurent Vivier <lvivier@...hat.com>, Cindy Lu <lulu@...hat.com>,
	jasowang@...hat.com, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Stefano Garzarella <sgarzare@...hat.com>,
	Yongji Xie <xieyongji@...edance.com>
Subject: Re: [PATCH v11 02/12] vduse: add vq group support

On Fri, Jan 09, 2026 at 04:24:20PM +0100, Eugenio Pérez wrote:
> @@ -1252,12 +1266,24 @@ static long vduse_dev_ioctl(struct file *file, unsigned int cmd,
>  		if (config.index >= dev->vq_num)
>  			break;
>  
> -		if (!is_mem_zero((const char *)config.reserved,
> -				 sizeof(config.reserved)))
> +		if (dev->api_version < VDUSE_API_VERSION_1 && config.group)
> +			break;
> +
> +		if (dev->api_version >= VDUSE_API_VERSION_1) {
> +			if (config.group >= dev->ngroups)
> +				break;
> +			if (dev->status & VIRTIO_CONFIG_S_DRIVER_OK)
> +				break;
> +		}
> +
> +		if (config.reserved1 ||
> +		    !is_mem_zero((const char *)config.reserved2,
> +				 sizeof(config.reserved2)))

Hmm but if api version is 0 then group should be 0 no?
We should validate.