linux-kernel - Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260111-bold-wolf-of-champagne-58fac7@quoll>
Date: Sun, 11 Jan 2026 11:18:42 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stafford Horne <shorne@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, 
	Linux OpenRISC <linux-openrisc@...r.kernel.org>, Linus Walleij <linusw@...nel.org>, 
	Bartosz Golaszewski <brgl@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO

On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
> Add a device tree binding for the opencores GPIO controller.
> 
> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
> 
> Link: https://opencores.org/projects/gpio
> Signed-off-by: Stafford Horne <shorne@...il.com>
> ---
> Since v2:
>  - Fixup patch to simply add opencores,gpio and add an example.

Simplify? You completely changed the meaning of binding here - now
device is not compatible.

I don't know which one is correct, but your changelog must explain why
now devices are not compatible but they were before.

> Since v1:
>  - Fix schema to actually match the example.
> 
>  Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> index ee5d5d25ae82..d44edc181e0a 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> @@ -23,6 +23,7 @@ properties:
>        - ni,169445-nand-gpio
>        - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
>        - intel,ixp4xx-expansion-bus-mmio-gpio
> +      - opencores,gpio
>  
>    big-endian: true
>  
> @@ -160,3 +161,11 @@ examples:
>              intel,ixp4xx-eb-write-enable = <1>;
>          };
>      };
> +
> +    gpio@...00000 {

Please do not grow the examples if they are exactly the same as other.

> +        compatible = "opencores,gpio";
> +        reg = <0x91000000 0x1>, <0x91000001 0x1>;
> +        reg-names = "dat", "dirout";
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +    };
> -- 
> 2.51.0
>