linux-kernel - Re: [PATCH 3/3] iio: dac: Add MAX22007 DAC driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260111115017.62802a56@jic23-huawei>
Date: Sun, 11 Jan 2026 11:50:17 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Janani Sunil <jan.sun97@...il.com>
Cc: Jonathan Cameron <jonathan.cameron@...wei.com>, Janani Sunil
 <janani.sunil@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Alexandru Ardelean
 <alexandru.ardelean@...log.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Jonathan Corbet <corbet@....net>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, gastmaier@...il.com
Subject: Re: [PATCH 3/3] iio: dac: Add MAX22007 DAC driver support

On Wed, 7 Jan 2026 16:28:31 +0100
Janani Sunil <jan.sun97@...il.com> wrote:

> Hi Jonathan,
> 
> Thank you for your review.
> 
> On 12/19/25 18:25, Jonathan Cameron wrote:
> > On Fri, 19 Dec 2025 16:31:17 +0100
> > Janani Sunil <janani.sunil@...log.com> wrote:
> >  
> >> Add support for the MAX22007 4 channel DAC
> >> that drives a voltage or current output on each channel.  
> > wrap to 75 chars rather than 50-60ish  
> 
> Noted. Will correct this.
> 
> >> Signed-off-by: Janani Sunil <janani.sunil@...log.com>  
> > Hi Janani
> >
> > A few minor things inline.  Also add turning on any required
> > power supplies.  See how other drivers do it with a single call
> > in in probe. If your board is using always on supplies it will just
> > work as a stub regulator will be provided by the regulator core.
> >
> >
> > Thanks,
> >
> > Jonathan  
> 
> Will take a reference from the other drivers and add the power supply configurations.

Hi Janani,

A small process thing you should take into account for future replies.
Generally kernel mailing lists are very high volume with a lot of review
feedback. As such we tend to go for a balance of efficiency over politeness.

So when you agree to a particular bit of feedback, just crop out that
bit of the message in any reply (if you agree to all of it no need to reply at
all!).  That lets us focus in quickly on the bits that need more discussion.

The politeness bit is resolve by adding a thank alongside the change log
in the next version.  I end up sending this message to someone most weeks,
so don't worry about it!  It feels unnatural to all of us initially.

Thanks

Jonathan