linux-kernel - Re: [PATCH] drm/rockchip: dw_hdmi_qp: Switch to gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176813878524.3696030.14477314053977335785.b4-ty@sntech.de>
Date: Sun, 11 Jan 2026 14:39:49 +0100
From: Heiko Stuebner <heiko@...ech.de>
To: Sandy Huang <hjc@...k-chips.com>,
	Andy Yan <andy.yan@...k-chips.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc: Heiko Stuebner <heiko@...ech.de>,
	kernel@...labora.com,
	dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/rockchip: dw_hdmi_qp: Switch to gpiod_set_value_cansleep()


On Sat, 10 Jan 2026 23:12:11 +0200, Cristian Ciocaltea wrote:
> Since commit 20cf2aed89ac ("gpio: rockchip: mark the GPIO controller as
> sleeping"), the Rockchip GPIO chip operations potentially sleep, hence
> the kernel complains when trying to make use of the non-sleeping API:
> 
> [   16.653343] WARNING: drivers/gpio/gpiolib.c:3902 at gpiod_set_value+0xd0/0x108, CPU#5: kworker/5:1/93
> ...
> [   16.678470] Hardware name: Radxa ROCK 5B (DT)
> [   16.682374] Workqueue: events dw_hdmi_qp_rk3588_hpd_work [rockchipdrm]
> ...
> [   16.729314] Call trace:
> [   16.731846]  gpiod_set_value+0xd0/0x108 (P)
> [   16.734548]  dw_hdmi_qp_rockchip_encoder_enable+0xbc/0x3a8 [rockchipdrm]
> [   16.737487]  drm_atomic_helper_commit_encoder_bridge_enable+0x314/0x380 [drm_kms_helper]
> [   16.740555]  drm_atomic_helper_commit_tail_rpm+0xa4/0x100 [drm_kms_helper]
> [   16.743501]  commit_tail+0x1e0/0x2c0 [drm_kms_helper]
> [   16.746290]  drm_atomic_helper_commit+0x274/0x2b8 [drm_kms_helper]
> [   16.749178]  drm_atomic_commit+0x1f0/0x248 [drm]
> [   16.752000]  drm_client_modeset_commit_atomic+0x490/0x5d0 [drm]
> [   16.754954]  drm_client_modeset_commit_locked+0xf4/0x400 [drm]
> [   16.757911]  drm_client_modeset_commit+0x50/0x80 [drm]
> [   16.760791]  __drm_fb_helper_restore_fbdev_mode_unlocked+0x9c/0x170 [drm_kms_helper]
> [   16.763843]  drm_fb_helper_hotplug_event+0x340/0x368 [drm_kms_helper]
> [   16.766780]  drm_fbdev_client_hotplug+0x64/0x1d0 [drm_client_lib]
> [   16.769634]  drm_client_hotplug+0x178/0x240 [drm]
> [   16.772455]  drm_client_dev_hotplug+0x170/0x1c0 [drm]
> [   16.775303]  drm_connector_helper_hpd_irq_event+0xa4/0x178 [drm_kms_helper]
> [   16.778248]  dw_hdmi_qp_rk3588_hpd_work+0x44/0xb8 [rockchipdrm]
> [   16.781080]  process_one_work+0xc3c/0x1658
> [   16.783719]  worker_thread+0xa24/0xc40
> [   16.786333]  kthread+0x3b4/0x3d8
> [   16.788889]  ret_from_fork+0x10/0x20
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: dw_hdmi_qp: Switch to gpiod_set_value_cansleep()
      commit: db8061bbb9b23534ecd69bccdfbd70f5c9543189

Best regards,
-- 
Heiko Stuebner <heiko@...ech.de>