linux-kernel - Re: [PATCH v2] serial: 8250_pci: Fix broken RS485 for F81504/508/512

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026011158--1d2d@gregkh>
Date: Sun, 11 Jan 2026 15:16:31 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Marnix Rijnart <marnix.rijnart@...ll.eu>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, regressions@...ts.linux.dev,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] serial: 8250_pci: Fix broken RS485 for F81504/508/512

On Sun, Jan 11, 2026 at 02:59:17PM +0100, Marnix Rijnart wrote:
> v1: https://patch.msgid.link/20250923221756.26770-1-marnix.rijnart@iwell.eu
> Changes: 
>  * Added fixes tags
>  * Cc stable
> 
> Commit 4afeced ("serial: core: fix sanitizing check for RTS settings")

Please use more digits here, "4afeced55baa", like you did in the Fixes:
lines.

> introduced a regression making it impossible to unset
> SER_RS485_RTS_ON_SEND from userspace if SER_RS485_RTS_AFTER_SEND is
> unsupported. Because these devices need RTS to be low on TX (fecf27a)
> they are effectively broken.
> 
> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND,
> so fix this by announcing support for SER_RS485_RTS_AFTER_SEND,
> similar to commit 068d35a.

You can line-wrap at 72 columns, and again, use more digits for the
commit, and spell out the full name of the commit.

> Fixes: 4afeced55baa ("serial: core: fix sanitizing check for RTS settings")
> Fixes: fecf27a373f5 ("serial: 8250_pci: add RS485 for F81504/508/512")
> Cc: stable@...r.kernel.org

So where does this need to be backported to, where the first commit is,
or the second?

thanks,

greg k-h