linux-kernel - Re: [PATCH 2/2] drm/msm: Fix GMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <oukfjvwbzi2z4xu43k3wapbu6fuzromxfxkxbyaj3spmvf6osf@bjmt42ui2peq>
Date: Sun, 11 Jan 2026 21:48:23 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Rob Clark <rob.clark@....qualcomm.com>
Cc: dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, Sean Paul <sean@...rly.run>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Akhil P Oommen <akhilpo@....qualcomm.com>,
        Dmitry Baryshkov <lumag@...nel.org>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        Jessica Zhang <jesszhan0024@...il.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] drm/msm: Fix GMEM_BASE for gen8

On Sat, Jan 10, 2026 at 06:23:59PM -0800, Rob Clark wrote:
> On Sat, Jan 10, 2026 at 6:17 PM Dmitry Baryshkov
> <dmitry.baryshkov@....qualcomm.com> wrote:
> >
> > On Fri, Jan 09, 2026 at 07:37:29AM -0800, Rob Clark wrote:
> > > This should also be zero for gen8.
> > >
> > > Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support")
> > > Signed-off-by: Rob Clark <robin.clark@....qualcomm.com>
> > > ---
> > >  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > > index 1c80909e63ca..d5fe6f6f0dec 100644
> > > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > > @@ -376,8 +376,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx,
> > >               *value = adreno_gpu->info->gmem;
> > >               return 0;
> > >       case MSM_PARAM_GMEM_BASE:
> > > -             if (adreno_is_a650_family(adreno_gpu) ||
> > > -                 adreno_is_a740_family(adreno_gpu))
> > > +             if (adreno_gpu->info->family >= ADRENO_6XX_GEN4)
> >
> > What about a7xx gen1? should it also be 0?
> 
> *probably*.. I'm guessing this was incorrect before

I'd at least mention it in the commit message.

> 
> BR,
> -R
> 
> >
> > >                       *value = 0;
> > >               else
> > >                       *value = 0x100000;
> > > --
> > > 2.52.0
> > >
> >
> > --
> > With best wishes
> > Dmitry

-- 
With best wishes
Dmitry