linux-kernel - Re: [PATCH] kho: init alloc tags when restoring pages from reserved memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpFoR-vFN9Smw4jpd94h4B0PjVJXTjY7fDamz7vyfBZi2w@mail.gmail.com>
Date: Sun, 11 Jan 2026 11:58:36 -0800
From: Suren Baghdasaryan <surenb@...gle.com>
To: Mike Rapoport <rppt@...nel.org>
Cc: ranxiaokai627@....com, graf@...zon.com, pasha.tatashin@...een.com, 
	pratyush@...nel.org, akpm@...ux-foundation.org, kexec@...ts.infradead.org, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, ran.xiaokai@....com.cn
Subject: Re: [PATCH] kho: init alloc tags when restoring pages from reserved memory

On Sun, Jan 11, 2026 at 1:09 AM Mike Rapoport <rppt@...nel.org> wrote:
>
> On Fri, Jan 09, 2026 at 10:42:51AM +0000, ranxiaokai627@....com wrote:
> > From: Ran Xiaokai <ran.xiaokai@....com.cn>
> >
> > Memblock pages (including reserved memory) should have their allocation
> > tags initialized to CODETAG_EMPTY via clear_page_tag_ref() before being
> > released to the page allocator. When kho restores pages through
> > kho_restore_page(), missing this call causes mismatched
> > allocation/deallocation tracking and warning message:
> > alloc_tag was not set.
> >
> > Add missing clear_page_tag_ref() annotation in kho_restore_page() to
> > fix this.
> >
> > Signed-off-by: Ran Xiaokai <ran.xiaokai@....com.cn>
>
> Reviewed-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

Reviewed-by: Suren Baghdasaryan <surenb@...gle.com>

>
> > ---
> >  kernel/liveupdate/kexec_handover.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> > index cd6b3fb9dcae..2d47f2c50bd8 100644
> > --- a/kernel/liveupdate/kexec_handover.c
> > +++ b/kernel/liveupdate/kexec_handover.c
> > @@ -268,6 +268,7 @@ static struct page *kho_restore_page(phys_addr_t phys, bool is_folio)
> >       else
> >               kho_init_pages(page, nr_pages);
> >
> > +     clear_page_tag_ref(page);
> >       adjust_managed_page_count(page, nr_pages);
> >       return page;
> >  }
> > --
> > 2.25.1
> >
> >
>
> --
> Sincerely yours,
> Mike.