linux-kernel - Re: [PATCH v8] rust: add new macro for common bitflag operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mXjEQd45+U7=UOfmdiK6zX_MFnnTT2Z4-a3ENF888i9Q@mail.gmail.com>
Date: Sun, 11 Jan 2026 21:06:42 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Filipe Xavier <felipeaggger@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, daniel.almeida@...labora.com, 
	rust-for-linux@...r.kernel.org, felipe_life@...e.com, 
	linux-kernel@...r.kernel.org, Lyude Paul <lyude@...hat.com>
Subject: Re: [PATCH v8] rust: add new macro for common bitflag operations

On Sun, Jan 11, 2026 at 2:33 PM Filipe Xavier <felipeaggger@...il.com> wrote:
>
> +// SPDX-License-Identifier: GPL-2.0
> +
> +//! Common helper for declaring bitflag and bitmask types.
> +///
> +/// This macro takes as input:

So I didn't mean to convert the first line to `//!`, but to add
documentation to the module between the SPDX line and the
documentation for the item.

Please see how other files do it, e.g. `rust/kernel/slice.rs` and
`rust/kernel/irq.rs` are similar cases (no `use` blocks between `//!`
and the first item).

But please wait a few days in case there is any other feedback --
hopefully we are getting finally there.

(By the way, in general, it is good to reply to the feedback messages
you get, to confirm or not whether you applied a particular
suggestion).

Thanks for updating the docs and being persistent!

Cheers,
Miguel