linux-kernel - Re: [PATCH 01/11] soc: qcom: ubwc: add missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db61a94f-c24f-453b-ba0f-68a1ca55f787@kernel.org>
Date: Sun, 11 Jan 2026 20:58:46 +0000
From: Bryan O'Donoghue <bod@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Rob Clark <robin.clark@....qualcomm.com>, Dmitry Baryshkov
 <lumag@...nel.org>, Abhinav Kumar <abhinav.kumar@...ux.dev>,
 Jessica Zhang <jesszhan0024@...il.com>, Sean Paul <sean@...rly.run>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Akhil P Oommen <akhilpo@....qualcomm.com>,
 Vikash Garodia <vikash.garodia@....qualcomm.com>,
 Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
 linux-media@...r.kernel.org
Subject: Re: [PATCH 01/11] soc: qcom: ubwc: add missing include

On 10/01/2026 19:37, Dmitry Baryshkov wrote:
> The header has a function which calls pr_err(). Don't require users of
> the header to include <linux/printk.h> and include it here.
> 
> Fixes: 87cfc79dcd60 ("drm/msm/a6xx: Resolve the meaning of UBWC_MODE")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>   include/linux/soc/qcom/ubwc.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h
> index 0a4edfe3d96d..f052e241736c 100644
> --- a/include/linux/soc/qcom/ubwc.h
> +++ b/include/linux/soc/qcom/ubwc.h
> @@ -8,6 +8,7 @@
>   #define __QCOM_UBWC_H__
> 
>   #include <linux/bits.h>
> +#include <linux/printk.h>
>   #include <linux/types.h>
> 
>   struct qcom_ubwc_cfg_data {
> 
> --
> 2.47.3
> 
> 
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>