linux-kernel - Re: [PATCH] btrfs: fix memory leaks in create_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2539a74d-9276-4b82-8e67-80581ff7dcb9@suse.com>
Date: Mon, 12 Jan 2026 07:36:29 +1030
From: Qu Wenruo <wqu@...e.com>
To: Jiasheng Jiang <jiashengjiangcool@...il.com>, Chris Mason <clm@...com>,
 David Sterba <dsterba@...e.com>, Jeff Mahoney <jeffm@...e.com>,
 Liu Bo <bo.li.liu@...cle.com>, Nikolay Borisov <nborisov@...e.com>,
 linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: fix memory leaks in create_space_info error paths



在 2026/1/12 05:50, Jiasheng Jiang 写道:
> In create_space_info(), the 'space_info' object is allocated at the
> beginning of the function. However, there are two error paths where the
> function returns an error code without freeing the allocated memory:
> 
> 1. When create_space_info_sub_group() fails in zoned mode.
> 2. When btrfs_sysfs_add_space_info_type() fails.
> 
> In both cases, 'space_info' has not yet been added to the
> fs_info->space_info list, resulting in a memory leak. Fix this by
> adding an error handling label to kfree(space_info) before returning.
> 
> Fixes: 2be12ef79fe9 ("btrfs: Separate space_info create/update")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>

Reviewed-by: Qu Wenruo <wqu@...e.com>

Thanks,
Qu

> ---
>   fs/btrfs/space-info.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
> index 6babbe333741..3f08e450f796 100644
> --- a/fs/btrfs/space-info.c
> +++ b/fs/btrfs/space-info.c
> @@ -306,18 +306,22 @@ static int create_space_info(struct btrfs_fs_info *info, u64 flags)
>   							  0);
>   
>   		if (ret)
> -			return ret;
> +			goto out_free;
>   	}
>   
>   	ret = btrfs_sysfs_add_space_info_type(space_info);
>   	if (ret)
> -		return ret;
> +		goto out_free;
>   
>   	list_add(&space_info->list, &info->space_info);
>   	if (flags & BTRFS_BLOCK_GROUP_DATA)
>   		info->data_sinfo = space_info;
>   
>   	return ret;
> +
> +out_free:
> +	kfree(space_info);
> +	return ret;
>   }
>   
>   int btrfs_init_space_info(struct btrfs_fs_info *fs_info)