linux-kernel - Re: [PATCH v2 1/4] HID: hid-ids: Add SteelSeries Arctis headset device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e5573c900fdf4057bf8a599d85413ed94ea0e9f.camel@hadess.net>
Date: Mon, 12 Jan 2026 14:08:01 +0100
From: Bastien Nocera <hadess@...ess.net>
To: Sriman Achanta <srimanachanta@...il.com>, Jiri Kosina
 <jikos@...nel.org>,  Benjamin Tissoires	 <bentiss@...nel.org>,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] HID: hid-ids: Add SteelSeries Arctis headset
 device IDs

On Sun, 2026-01-11 at 23:19 -0500, Sriman Achanta wrote:
> Add USB device IDs for the complete SteelSeries Arctis headset
> lineup,
> including:
> - Arctis 1, 1 Wireless, 7, 7P, 7X variants
> - Arctis 7+ series (PS5, Xbox, Destiny editions)
> - Arctis 9 Wireless
> - Arctis Pro Wireless
> - Arctis Nova 3, 3P, 3X
> - Arctis Nova 5, 5X
> - Arctis Nova 7 series (multiple variants and special editions)
> - Arctis Nova Pro Wireless and Pro X
> 
> This also fixes the existing ARCTIS_1 ID to use the correct product
> ID
> (0x12b3 instead of 0x12b6, which is actually the Arctis 1 Xbox
> variant).

"This also fixes" usually is a good way to tell you that this should
have been a separate patch.

It would be useful if you could change the indentation in a first
patch, "fix" the USB ID in a second patch, and add new IDs in a third
patch. Note that in your second patch, you'll need to change the source
code to use that new identifier otherwise you'll be breaking my headset
:)

Please make sure to CC: me on future patchsets you send.

> 
> These IDs will be used by the updated hid-steelseries driver to
> provide
> battery monitoring, sidetone control, and other device-specific
> features
> for these wireless gaming headsets.
> 
> Signed-off-by: Sriman Achanta <srimanachanta@...il.com>
> ---
>  drivers/hid/hid-ids.h | 33 +++++++++++++++++++++++++++++----
>  1 file changed, 29 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index d31711f1aaec..f4f91fb4c2b9 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -1303,10 +1303,35 @@
>  #define USB_DEVICE_ID_STEAM_CONTROLLER_WIRELESS	0x1142
>  #define USB_DEVICE_ID_STEAM_DECK	0x1205
>  
> -#define USB_VENDOR_ID_STEELSERIES	0x1038
> -#define USB_DEVICE_ID_STEELSERIES_SRWS1	0x1410
> -#define USB_DEVICE_ID_STEELSERIES_ARCTIS_1  0x12b6
> -#define USB_DEVICE_ID_STEELSERIES_ARCTIS_9  0x12c2
> +#define USB_VENDOR_ID_STEELSERIES			0x1038
> +#define
> USB_DEVICE_ID_STEELSERIES_SRWS1			0x1410
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_1		0x12b3
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_1_X		0x12b6
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7		0x1260
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_P		0x12d5
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_X		0x12d7
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_7_GEN2		0x12ad
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS		0x220e
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS_P	0x2212
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS_X	0x2216
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS_DESTINY	0x2236
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_9		0x12c2
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_PRO		0x1290
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_3		0x12ec
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_3_P	0x2269
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_3_X	0x226d
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_5		0x2232
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_5_X	0x2253
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7		0x2202
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_X	0x2206
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_P	0x220a
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_X_REV2	0x2258
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_DIABLO	0x223a
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_WOW	0x227a
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_GEN2	0x227e
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_X_GEN2	0x229e
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_PRO	0x12e0
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_PRO_X	0x12e5
>  
>  #define USB_VENDOR_ID_SUN		0x0430
>  #define USB_DEVICE_ID_RARITAN_KVM_DONGLE	0xcdab