linux-kernel - Re: [PATCH] rtc: max31335: use correct CONFIG symbol in IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9a59334e29ecf10ed8e6d737e5b918580446a69.camel@gmail.com>
Date: Mon, 12 Jan 2026 13:23:03 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>, Alexandre Belloni
	 <alexandre.belloni@...tlin.com>, linux-rtc@...r.kernel.org
Subject: Re: [PATCH] rtc: max31335: use correct CONFIG symbol in
 IS_REACHABLE()

On Wed, 2026-01-07 at 20:54 -0800, Randy Dunlap wrote:
> IS_REACHABLE() is meant to be used with full symbol names from a kernel
> .config file, not the shortened symbols used in Kconfig files, so
> change HWMON to CONFIG_HWMON in 3 places.
> 
> Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---

Acked-by: Nuno Sá <nuno.sa@...log.com>

> Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: linux-rtc@...r.kernel.org
> 
>  drivers/rtc/rtc-max31335.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- linux-next-20260107.orig/drivers/rtc/rtc-max31335.c
> +++ linux-next-20260107/drivers/rtc/rtc-max31335.c
> @@ -591,7 +591,7 @@ static struct nvmem_config max31335_nvme
>  	.size = MAX31335_RAM_SIZE,
>  };
>  
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
>  static int max31335_read_temp(struct device *dev, enum hwmon_sensor_types type,
>  			      u32 attr, int channel, long *val)
>  {
> @@ -672,7 +672,7 @@ static int max31335_clkout_register(stru
>  static int max31335_probe(struct i2c_client *client)
>  {
>  	struct max31335_data *max31335;
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
>  	struct device *hwmon;
>  #endif
>  	const struct chip_desc *match;
> @@ -727,7 +727,7 @@ static int max31335_probe(struct i2c_cli
>  		return dev_err_probe(&client->dev, ret,
>  				     "cannot register rtc nvmem\n");
>  
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
>  	if (max31335->chip->temp_reg) {
>  		hwmon = devm_hwmon_device_register_with_info(&client->dev, client->name,
> max31335,
>  							     &max31335_chip_info, NULL);