linux-kernel - Re: [PATCH] sched: Fix build for modules using set_tsk_need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260112145016.GA865736@pauld.westford.csb>
Date: Mon, 12 Jan 2026 09:50:16 -0500
From: Phil Auld <pauld@...hat.com>
To: Gabriele Monaco <gmonaco@...hat.com>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] sched: Fix build for modules using set_tsk_need_resched()

On Mon, Jan 12, 2026 at 03:04:13PM +0100 Gabriele Monaco wrote:
> Commit adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model")
> added a tracepoint to the need_resched action that can be triggered also
> by set_tsk_need_resched.
> This function was previously accessible from out-of-tree modules but
> it's no longer available because the __trace_set_need_resched() symbol
> is not exported (together with the tracepoint itself, which was exported
> in a separate patch) and building such modules fails.
> 
> Export __trace_set_need_resched to modules to fix those build issues.
> 
> Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model")
> Cc: Phil Auld <pauld@...hat.com>
> Signed-off-by: Gabriele Monaco <gmonaco@...hat.com>
> ---
>  kernel/sched/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 60afadb6eede..a490d34cc65a 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1136,6 +1136,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif)
>  {
>  	trace_sched_set_need_resched_tp(curr, smp_processor_id(), tif);
>  }
> +EXPORT_SYMBOL_GPL(__trace_set_need_resched);
>  
>  void resched_curr(struct rq *rq)
>  {
> 
> base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193
> -- 
> 2.52.0
> 

Thanks Gabriele!  And good catch that the other patch is not sufficient.


Reviewed-by: Phil Auld <pauld@...hat.com>


--