linux-kernel - Re: [PATCH v2 1/2] x86/virt/tdx: Retrieve TDX module version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0cc6afe-0f58-4314-9a77-34c5b005b677@intel.com>
Date: Mon, 12 Jan 2026 06:56:58 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Xiaoyao Li <xiaoyao.li@...el.com>, Vishal Verma
 <vishal.l.verma@...el.com>, linux-kernel@...r.kernel.org,
 linux-coco@...ts.linux.dev, kvm@...r.kernel.org
Cc: x86@...nel.org, Chao Gao <chao.gao@...el.com>,
 Dan Williams <dan.j.williams@...el.com>, Kai Huang <kai.huang@...el.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, Kiryl Shutsemau <kas@...nel.org>,
 Rick Edgecombe <rick.p.edgecombe@...el.com>
Subject: Re: [PATCH v2 1/2] x86/virt/tdx: Retrieve TDX module version

On 1/11/26 18:25, Xiaoyao Li wrote:
> ... I know it's because minor_version has the least field ID among the
> three. But the order of the field IDs doesn't stand for the order of the
> reading. Reading the middle part y of x.y.z as first step looks a bit odd.

I wouldn't sweat it either way. Reading 4, 3, 5 would also look odd. I'm
fine with it as-is in the patch.