linux-kernel - Re: [PATCH v2] arm64: dts: imx93-11x11-frdm: Add MQS audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZAU7xEGtK-d-KM5e3RcW2ayASAqwZsU2VGLAzvJZwzQng@mail.gmail.com>
Date: Mon, 12 Jan 2026 17:19:02 +0200
From: Daniel Baluta <daniel.baluta@...il.com>
To: Fabio Estevam <festevam@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, shawnguo@...nel.org, s.hauer@...gutronix.de, 
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	kernel@...gutronix.de, devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, haidong.zheng@....com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: imx93-11x11-frdm: Add MQS audio support

On Mon, Jan 12, 2026 at 4:38 PM Fabio Estevam <festevam@...il.com> wrote:
>
> On Mon, Jan 12, 2026 at 10:53 AM Daniel Baluta <daniel.baluta@....com> wrote:
>
> > +
> > +       sound-mqs {
> > +               compatible = "fsl,imx6sx-sdb-mqs",
> > +                            "fsl,imx-audio-mqs";
>
> Wouldn't it make more sense to use compatible = "fsl,imx-audio-mqs" instead?

Yes, this is a good catch. Will fix it in v3.

Discussion for future patches:

1) is it common practice to always have a more specific compatible
even if not used now.

e.g Use

compatible = "fsl,imx93-audio-frdm-mqs", "fsl,imx-audio-mqs";?

2) The current compatible:

compatible = "fsl,imx6sx-sdb-mqs",
            "fsl,imx-audio-mqs";

is already used for imx91-11x11-frdm.dts so I guess we should keep it like this
as this is already ABI right?