linux-kernel - Re: [PATCH v2 3/4] scripts/kernel-doc: ensure that comments are using our coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qe23kgv.fsf@trenco.lwn.net>
Date: Mon, 12 Jan 2026 08:43:28 -0700
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Linux Doc Mailing
 List <linux-doc@...r.kernel.org>, Mauro Carvalho Chehab
 <mchehab@...nel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
 linux-kernel@...r.kernel.org, Jani Nikula <jani.nikula@...el.com>
Subject: Re: [PATCH v2 3/4] scripts/kernel-doc: ensure that comments are
 using our coding style

Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:

> Along kernel-doc libs, we opted to have all comments starting/ending
> with a blank comment line. Use the same style here.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  scripts/kernel-doc.py | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/scripts/kernel-doc.py b/scripts/kernel-doc.py
> index 5d2f29e90ebe..7ccee4626478 100755
> --- a/scripts/kernel-doc.py
> +++ b/scripts/kernel-doc.py
> @@ -197,7 +197,9 @@ def main():
>      parser = argparse.ArgumentParser(formatter_class=argparse.RawTextHelpFormatter,
>                                       description=DESC)
>  
> +    #
>      # Normal arguments
> +    #
>  
>      parser.add_argument("-v", "-verbose", "--verbose", action="store_true",
>                          help="Verbose output, more warnings and other information.")

[nit] I approve of this kind of change, but I would get rid of the extra
blank lines, just like we do with C code.

(I wouldn't redo the series just for this).

Thanks,

jon