linux-kernel - Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for awinic,aw88261

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <19035a09-8b6b-4590-a816-82350c1389e3@app.fastmail.com>
Date: Mon, 12 Jan 2026 21:57:46 +0530
From: "Bharadwaj Raju" <bharadwaj.raju@...hinesoul.in>
To: "Krzysztof Kozlowski" <krzk@...nel.org>,
 "Liam Girdwood" <lgirdwood@...il.com>, "Mark Brown" <broonie@...nel.org>,
 "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>,
 "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>,
 "Weidong Wang" <wangweidong.a@...nic.com>
Cc: "Bhushan Shah" <bhushan.shah@...hinesoul.in>,
 "Luca Weiss" <luca.weiss@...rphone.com>,
 ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: document dvdd-supply property for
 awinic,aw88261

On Sun, 11 Jan 2026, at 9:40 PM, Krzysztof Kozlowski wrote:
> On 11/01/2026 13:48, Bharadwaj Raju wrote:
>> On Sun, 11 Jan 2026, at 5:00 PM, Krzysztof Kozlowski wrote:
>>> Why? Was it missing? Why require it, which is an ABI break (or is not?)?
>>> Why is ABI break allowed or what is its impact?
>> 
>> Right now there are no users of aw88261 in the kernel device tree sources.
>> This patch is part of an effort to mainline the FairPhone 5, for which we 
>> will add the first use of this compatible, and there we need to specify 
>> dvdd-supply for this chip's power supply.
>
> You mean the bindings were incomplete?

Yes, the chip needs DVDD to power on.

>> 
>> Since there are no present users, I thought it was OK to add a new required 
>> property. If not, I can make it optional.
>
> Nothing like that was explained in commit msg. Also your explanation
> above does not consider out of tree users of this ABI. That's fine in
> general, but needs reason why you are doing this.

After looking at other codec drivers, they generally make it optional 
in the binding but error out from probe if it can't be enabled.

I'll resend the series with it made optional.

Regards,
Bharadwaj