linux-kernel - Re: [PATCH v2] PCI: Provide pci_free_irq_vectors() for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFMR5480EBNW.2TGBZVU4XZ8U7@kernel.org>
Date: Mon, 12 Jan 2026 17:30:16 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Bjorn Helgaas" <bhelgaas@...gle.com>
Cc: "Boqun Feng" <boqun.feng@...il.com>, "Miguel Ojeda" <ojeda@...nel.org>,
 "Gary Guo" <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Joel Fernandes"
 <joelagnelf@...dia.com>, <linux-pci@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>, "Dirk
 Behme" <dirk.behme@...il.com>, "FUJITA Tomonori"
 <fujita.tomonori@...il.com>, "kernel test robot" <lkp@...el.com>, "Liang
 Jie" <liangjie@...iang.com>, "Drew Fustini" <fustini@...nel.org>, "David
 Gow" <davidgow@...gle.com>
Subject: Re: [PATCH v2] PCI: Provide pci_free_irq_vectors() for CONFIG_PCI=n

On Fri Dec 26, 2025 at 12:39 PM CET, Boqun Feng wrote:
> Commit 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI
> is disabled") fixed a build error by providing rust helpers when
> CONFIG_PCI_MSI=n. However the rust helpers rely on the
> pci_alloc_irq_vectors() function is defined, which is not true when
> CONFIG_PCI=n. There are multiple ways to fix this, e.g. a possible fix
> could be just remove the calling of pci_alloc_irq_vectors() since it's
> empty when CONFIG_PCI_MSI=n anyway. However, since PCI irq APIs, such as
> pci_alloc_irq_vectors(), are already defined even when CONFIG_PCI=n, the
> more reasonable fix is to define pci_alloc_irq_vectors() when
> CONFIG_PCI=n and this aligns with the situations of other primitives as
> well.
>
> Reported-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> Closes: https://lore.kernel.org/rust-for-linux/20251209014312.575940-1-fujita.tomonori@gmail.com/
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512220740.4Kexm4dW-lkp@intel.com/
> Reported-by: Liang Jie <liangjie@...iang.com>
> Closes: https://lore.kernel.org/rust-for-linux/20251222034415.1384223-1-buaajxlj@163.com/
> Fixes: 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI is disabled")
> Reviewed-by: Drew Fustini <fustini@...nel.org>
> Reviewed-by: David Gow <davidgow@...gle.com>
> Reviewed-by: Joel Fernandes <joelagnelf@...dia.com>
> Reviewed-by: Danilo Krummrich <dakr@...nel.org>
> Signed-off-by: Boqun Feng <boqun.feng@...il.com>

Bjorn, I just received another bug report due to this issue. Can you please pick
this up for the next -rc?

If you don't have anything else to send, I can pick it up as well. :)

Thanks,
Danilo