linux-kernel - Re: [PATCH] x86/sev: Use kfree_sensitive() when freeing a SNP message descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19d54b7b-df81-451d-b22e-a7fb2e90ba73@amd.com>
Date: Mon, 12 Jan 2026 10:38:51 -0600
From: Tom Lendacky <thomas.lendacky@....com>
To: Borislav Petkov <bp@...en8.de>, Julia Lawall <julia.lawall@...ia.fr>
Cc: Nikunj A Dadhania <nikunj@....com>, linux-kernel@...r.kernel.org,
 oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH] x86/sev: Use kfree_sensitive() when freeing a SNP message
 descriptor

On 1/12/26 05:41, Borislav Petkov wrote:
> On Sat, Dec 20, 2025 at 03:25:46PM +0100, Julia Lawall wrote:
>> cocci warnings: (new ones prefixed by >>)
>>>> arch/x86/coco/sev/core.c:2838:12-13: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 2837)
> 
> From: "Borislav Petkov (AMD)" <bp@...en8.de>
> Date: Mon, 12 Jan 2026 12:37:49 +0100
> 
> Use the proper helper instead of an open-coded variant.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> Closes: https://lore.kernel.org/r/202512202235.WHPQkLZu-lkp@intel.com
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>

Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
> ---
>  arch/x86/coco/sev/core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index 379e0c09c7f3..38dad3f5f491 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
> @@ -1632,8 +1632,7 @@ void snp_msg_free(struct snp_msg_desc *mdesc)
>  	free_shared_pages(mdesc->request, sizeof(struct snp_guest_msg));
>  	iounmap((__force void __iomem *)mdesc->secrets);
>  
> -	memset(mdesc, 0, sizeof(*mdesc));
> -	kfree(mdesc);
> +	kfree_sensitive(mdesc);
>  }
>  EXPORT_SYMBOL_GPL(snp_msg_free);
>