linux-kernel - Re: [PATCH] iommu: amd: Fix uninitialized dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260112165139.7120-1-rakuram.e96@gmail.com>
Date: Mon, 12 Jan 2026 22:21:37 +0530
From: Rakuram Eswaran <rakuram.e96@...il.com>
To: vasant.hegde@....com
Cc: dan.carpenter@...aro.org,
	iommu@...ts.linux.dev,
	joro@...tes.org,
	linux-kernel@...r.kernel.org,
	lkp@...el.com,
	rakuram.e96@...il.com,
	robin.murphy@....com,
	suravee.suthikulpanit@....com,
	will@...nel.org
Subject: Re: [PATCH] iommu: amd: Fix uninitialized dev_data on probe failure

Hi Vasant, 

On Mon, 12 Jan 2026 at 10:42, Vasant Hegde <vasant.hegde@....com> wrote:
>
> On 1/10/2026 3:39 PM, JÃ¶rg RÃ¶del wrote:
> > On Sun, Dec 21, 2025 at 11:04:16PM +0530, Rakuram Eswaran wrote:
> >> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> >> index 5d45795c367a..075125f0f52b 100644
> >> --- a/drivers/iommu/amd/iommu.c
> >> +++ b/drivers/iommu/amd/iommu.c
> >> @@ -2426,7 +2426,7 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev)
> >>              dev_err(dev, "Failed to initialize - trying to proceed anyway\n");
> >>              iommu_dev = ERR_PTR(ret);
> >>              iommu_ignore_device(iommu, dev);
> >> -            goto out_err;
> >> +            return iommu_dev;
> >>      }
> >
> > This is not the right fix. It makes the function omit further initialization
> > steps which are needed event when iommu_init_device() fails (which it only does
> > on out-of-memory).
> >
> > The right fix is to initialize dev_data to NULL and check for that value before
> > dereferencing it further down to keep the current logic.
>
> Ack. I think this function needs rewrite. PCIe device capability
> check/enablement is scattered between this one and iommu_init_device(). I will
> fix it as part of other PASID related fixes/cleanups.
>
> I think for now below fix is good enough.
>
> @Rakuram, @Joerg, let me know if you want me to send proper patch?
>

Ok. 

Best Regards,
Rakuram