linux-kernel - Re: [PATCH v12 0/3] mm: Fix OOM killer inaccuracy on large many-core systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871pjuu4zn.fsf@linux.dev>
Date: Mon, 12 Jan 2026 09:15:40 -0800
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
  linux-kernel@...r.kernel.org,  "Paul E. McKenney" <paulmck@...nel.org>,
  Steven Rostedt <rostedt@...dmis.org>,  Masami Hiramatsu
 <mhiramat@...nel.org>,  Dennis Zhou <dennis@...nel.org>,  Tejun Heo
 <tj@...nel.org>,  Christoph Lameter <cl@...ux.com>,  Martin Liu
 <liumartin@...gle.com>,  David Rientjes <rientjes@...gle.com>,
  christian.koenig@....com,  Shakeel Butt <shakeel.butt@...ux.dev>,
  SeongJae Park <sj@...nel.org>,  Michal Hocko <mhocko@...e.com>,  Johannes
 Weiner <hannes@...xchg.org>,  Sweet Tea Dorminy
 <sweettea-kernel@...miny.me>,  Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>,  "Liam R . Howlett"
 <liam.howlett@...cle.com>,  Mike Rapoport <rppt@...nel.org>,  Suren
 Baghdasaryan <surenb@...gle.com>,  Vlastimil Babka <vbabka@...e.cz>,
  Christian Brauner <brauner@...nel.org>,  Wei Yang
 <richard.weiyang@...il.com>,  David Hildenbrand <david@...hat.com>,
  Miaohe Lin <linmiaohe@...wei.com>,  Al Viro <viro@...iv.linux.org.uk>,
  linux-mm@...ck.org,  linux-trace-kernel@...r.kernel.org,  Yu Zhao
 <yuzhao@...gle.com>,  Mateusz Guzik <mjguzik@...il.com>,  Matthew Wilcox
 <willy@...radead.org>,  Baolin Wang <baolin.wang@...ux.alibaba.com>,
  Aboorva Devarajan <aboorvad@...ux.ibm.com>
Subject: Re: [PATCH v12 0/3] mm: Fix OOM killer inaccuracy on large
 many-core systems

Mathieu Desnoyers <mathieu.desnoyers@...icios.com> writes:

> On 2026-01-11 12:48, Andrew Morton wrote:
>> On Sun, 11 Jan 2026 10:02:46 -0500 Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
>> 
>>> Notable changes for v12:
>>>
>>> - Reduce per-CPU counters memory allocation size to sizeof long
>>>    (fixing mixup with sizeof intermediate cache line aligned items).
>>> - Use "long" counters types rather than "int".
>>> - get_mm_counter_sum() returns a precise sum.
>>> - Introduce and use functions to calculate the min/max possible precise
>>>    sum values associated with an approximate sum.
>> May I ask, as an early adopter, what is your overall impression of
>> the Gemini reviewbot?
>
> The review comments were all spot-on. This is the level of review I
> would expect from a good reviewer who spends a significant amount of
> effort digging into the proposed change to make sure the type limits
> are OK for the intended purpose stated in the commit message and that
> the intent stated in comments match the code.
>
> As a patch author, I find this feedback really useful. Is there
> an easy way to get this feedback privately before sending out my
> patches ?

If you need to review a limited number of patches, the easiest way to
use gemini cli/claude code or similar tools with a consumer grade
subscription (most are $20/month these days).
I maintain a pre-configured environment for Gemini:
git@...hub.com:rgushchin/kengp.git , but it's not hard to hack something
similar for other tools.

Thanks!