linux-kernel - Re: [PATCH v3] perf build: Raise minimum shellcheck version to 0.7.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWVDXUv0Jdon_nFB@x1>
Date: Mon, 12 Jan 2026 15:54:21 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Nicolas Schier <n.schier@....de>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	Michael Petlan <mpetlan@...hat.com>,
	Jakub Brnak <jbrnak@...hat.com>,
	Veronika Molnarova <vmolnaro@...hat.com>,
	Philipp Hahn <p.hahn@....de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nicolas Schier <nsc@...nel.org>
Subject: Re: [PATCH v3] perf build: Raise minimum shellcheck version to 0.7.2

On Thu, Jan 08, 2026 at 12:29:10PM +0100, Nicolas Schier wrote:
> Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> systems with shellcheck versions below 0.7.2 will automatically skip the
> shell script checking, even if NO_SHELLCHECK is unset.
> 
> Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> paths"), shellcheck versions before 0.7.2 break the perf build with
> several SC1090 [2] warnings due to its too strict dynamic source
> handling [1], e.g.:
> 
>   In tests/shell/base_probe/test_line_semantics.sh line 20:
>   . "$DIR_PATH/../common/init.sh"
>     ^---------------------------^ SC1090: Can't follow non-constant source. Use a directive to specify location.
> 
> Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")

Thanks, applied to perf-tools-next,

- Arnaldo