linux-kernel - Re: [PATCH] ecryptfs: Add missing gotos in ecryptfs_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWVKMoUMBwnYWCPw@yaupon>
Date: Mon, 12 Jan 2026 13:23:30 -0600
From: Tyler Hicks <code@...icks.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Al Viro <viro@...iv.linux.org.uk>, Ard Biesheuvel <ardb@...nel.org>,
	Zipeng Zhang <zhangzipeng0@...mail.com>,
	Christian Brauner <brauner@...nel.org>,
	Eric Biggers <ebiggers@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, stable@...r.kernel.org,
	ecryptfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ecryptfs: Add missing gotos in ecryptfs_read_metadata

On 2026-01-11 13:28:17, Thorsten Blum wrote:
> On 11. Jan 2026, at 02:08, Al Viro wrote:
> > On Sun, Jan 11, 2026 at 01:36:52AM +0100, Thorsten Blum wrote:
> >> Add two missing goto statements to exit ecryptfs_read_metadata() when an
> >> error occurs.
> >> 
> >> The first goto is required; otherwise ECRYPTFS_METADATA_IN_XATTR may be
> >> set when xattr metadata is enabled even though parsing the metadata
> >> failed. The second goto is not strictly necessary, but it makes the
> >> error path explicit instead of relying on falling through to 'out'.
> > 
> > Ugh...  IMO the whole thing from the point we'd successfully allocated
> > the page to the point where we start to clear it ought to be in a separate
> > helper.  Something like this, perhaps?
> 
> I wanted to keep the fix simple, but I'm happy to refactor the function
> if that's preferred. Any preferences, Tyler?

I typically like the multi-patch approach of a minimal, easy-to-backport
fix first and then a more complete cleanup/improvement in the followup
patch(es).

Tyler

> 
> Thanks,
> Thorsten
>