| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aWVPgtRnxfL2zSSu@kekkonen.localdomain>
Date: Mon, 12 Jan 2026 21:46:10 +0200
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Matthias Fend <matthias.fend@...end.at>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Hans Verkuil <hverkuil@...nel.org>,
Hans de Goede <hansg@...nel.org>,
Ricardo Ribalda <ribalda@...omium.org>,
André Apitzsch <git@...tzsch.eu>,
Tarang Raval <tarang.raval@...iconsignals.io>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
Sylvain Petinot <sylvain.petinot@...s.st.com>,
Dongcheng Yan <dongcheng.yan@...el.com>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Alan Stern <stern@...land.harvard.edu>,
Jingjing Xiong <jingjing.xiong@...el.com>,
Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
Mehdi Djait <mehdi.djait@...ux.intel.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
Svyatoslav Ryhel <clamor95@...il.com>, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Hao Yao <hao.yao@...el.com>,
Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH v7 1/2] media: dt-bindings: i2c: add Himax HM1246 image
sensor
Hi Matthias,
On Mon, Jan 12, 2026 at 03:49:32PM +0100, Matthias Fend wrote:
> Add YAML device tree binding for Himax HM1246 image sensor.
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Matthias Fend <matthias.fend@...end.at>
> ---
> .../bindings/media/i2c/himax,hm1246.yaml | 117 +++++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 124 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..deecc1105105a67e81d1ddb7f31324baa8188f88
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 Matthias Fend <matthias.fend@...end.at>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/himax,hm1246.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Himax HM1246-AWD 1/3.7-Inch megapixel SoC image sensor
> +
> +maintainers:
> + - Matthias Fend <matthias.fend@...end.at>
> +
> +description:
> + The Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active
> + array size of 1296 x 976. It is programmable through an I2C interface and
> + connected via parallel bus.
> +
> +allOf:
> + - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> + compatible:
> + const: himax,hm1246
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + description: Input reference clock (6 - 27 MHz)
> + maxItems: 1
> +
> + reset-gpios:
> + description: Active low XSHUTDOWN pin
> + maxItems: 1
> +
> + avdd-supply:
> + description: Power for analog circuit (3.0 - 3.6 V)
> +
> + iovdd-supply:
> + description: Power for I/O circuit (1.7 - 3.6 V)
> +
> + dvdd-supply:
> + description: Power for digital circuit (1.5 / 1.8 V)
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> + description: Parallel video output port
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + hsync-active:
> + default: 1
> +
> + vsync-active:
> + default: 1
> +
> + pclk-sample:
> + default: 0
I think you should have bus-width here as well -- either make it mandatory
or add a default.
> +
> + required:
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - avdd-supply
> + - iovdd-supply
> + - dvdd-supply
> + - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@24 {
> + compatible = "himax,hm1246";
> + reg = <0x24>;
> +
> + clocks = <&hm1246_clk>;
> +
> + reset-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>;
> +
> + avdd-supply = <&hm1246_avdd>;
> + iovdd-supply = <&hm1246_iovdd>;
> + dvdd-supply = <&hm1246_dvdd>;
> +
> + orientation = <2>;
> + rotation = <0>;
> +
> + port {
> + endpoint {
> + remote-endpoint = <&isp_par_in>;
> + bus-width = <10>;
> + hsync-active = <1>; /* active high */
> + vsync-active = <1>; /* active high */
> + pclk-sample = <1>; /* sample on rising edge */
> + link-frequencies = /bits/ 64 <42200000>;
> + };
> + };
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 752ccaea38b0ee74282e06f233463eba122fa92c..c09de45c5260b70af8a524721d4a999a1efa415d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11290,6 +11290,13 @@ L: linux-kernel@...r.kernel.org
> S: Maintained
> F: drivers/misc/hisi_hikey_usb.c
>
> +HIMAX HM1246 SENSOR DRIVER
> +M: Matthias Fend <matthias.fend@...end.at>
> +L: linux-media@...r.kernel.org
> +S: Maintained
> +T: git git://linuxtv.org/media_tree.git
I think this can be dropped as I understand you don't have commit access.
> +F: Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> +
> HIMAX HX83112B TOUCHSCREEN SUPPORT
> M: Job Noorman <job@...rman.info>
> L: linux-input@...r.kernel.org
>
--
Kind regards,
Sakari Ailus
Powered by blists - more mailing lists