linux-kernel - Re: [PATCH] init/main.c: check if rdinit was explicitly set before printing warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260112121338.c33de740d918313612b30791@linux-foundation.org>
Date: Mon, 12 Jan 2026 12:13:38 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Lillian Berry <lillian@...r-ark.net>
Cc: Ahmad Fatoum <a.fatoum@...gutronix.de>, linux-kernel@...r.kernel.org, Al
 Viro <viro@...iv.linux.org.uk>, Leonard Goehrs <lgo@...gutronix.de>,
 "kernel @ pengutronix . de" <kernel@...gutronix.de>
Subject: Re: [PATCH] init/main.c: check if rdinit was explicitly set before
 printing warning

On Sun, 11 Jan 2026 07:56:35 -0500 Lillian Berry <lillian@...r-ark.net> wrote:

> The rdinit parameter is set by default, and attempted during boot even
> if not specified in the command line. Only print the warning about
> rdinit being inaccessible if the rdinit value was found in command line;
> it's just noise otherwise.
> 
> ...
>
> --- a/init/main.c
> +++ b/init/main.c
> @@ -162,6 +162,7 @@ static size_t initargs_offs;
>  
>  static char *execute_command;
>  static char *ramdisk_execute_command = "/init";
> +static bool ramdisk_execute_command_set;

We can use __initdata. yes?

--- a/init/main.c~init-mainc-check-if-rdinit-was-explicitly-set-before-printing-warning-fix
+++ a/init/main.c
@@ -162,7 +162,7 @@ static size_t initargs_offs;

 static char *execute_command;
 static char *ramdisk_execute_command = "/init";
-static bool ramdisk_execute_command_set;
+static bool __initdata ramdisk_execute_command_set;

 /*
  * Used to generate warnings if static_key manipulation functions are used
_

I suspect there are other things around here which could be moved into
__initdata.