linux-kernel - Re: [PATCH] fixup! genirq: Add interrupt redirection infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2105d279ce5df15bc15e29a5e21ab3c5b6e440a1.camel@redhat.com>
Date: Mon, 12 Jan 2026 15:24:56 -0500
From: Radu Rendec <rrendec@...hat.com>
To: Thomas Gleixner <tglx@...nel.org>
Cc: Manivannan Sadhasivam <mani@...nel.org>, Daniel Tsai	
 <danielsftsai@...gle.com>, Marek Behún
 <kabel@...nel.org>,  Krishna Chaitanya Chundru	 <quic_krichai@...cinc.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Rob Herring	 <robh@...nel.org>,
 Krzysztof Wilczyński	 <kwilczynski@...nel.org>, Lorenzo
 Pieralisi <lpieralisi@...nel.org>, Jingoo Han	 <jingoohan1@...il.com>,
 Brian Masney <bmasney@...hat.com>, Eric Chanudet	 <echanude@...hat.com>,
 Alessandro Carminati <acarmina@...hat.com>, Jared Kangas	
 <jkangas@...hat.com>, Jon Hunter <jonathanh@...dia.com>, 
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org, 
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH] fixup! genirq: Add interrupt redirection infrastructure

Hello, Thomas!

On Sun, 2026-01-11 at 22:52 +0100, Thomas Gleixner wrote:
> Thanks for taking care of this, but this is not really the way how it
> works.
> 
> $subject: fixup!.... is neither a valid nor a useful subject line.
> 
> $subject is documented to be a concise summary of the change at hand, so
> in this case this should be something like:
> 
>    [PATCH] genirq: Update effective affinity for redirected interrupts
> 
> [snip]
> 
> It also lacks a 'Fixes:' tag as the code is already merged, no?
> 
> 
> [snip]

Apologies, and thanks a lot for taking the time to provide such
detailed feedback!

I mistakenly assumed the original commit could still be *amended*, and
the format I used was a (failed) attempt at asking that. I didn't
realize the commit was immutable once included in the tip tree, and
didn't pay much attention to the commit message because I thought it
would be discarded anyway while amending.

In my defense, $subject: "fixup! <original commit subject>" is a format
recognized by `git rebase` and used on some subsystems to fix already
accepted patches *before* they are merged upstream. It just doesn't
apply here. Lesson learned!

I will re-send it using the standard format for fixing a commit that's
already merged, and follow all the suggestions you made.

-- 
Best regards,
Radu