linux-kernel - Re: [PATCH] perf/core: make nr_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b79ba06d-ec06-4f8f-85cf-72ea6080b041@linux.intel.com>
Date: Mon, 12 Jan 2026 13:31:06 +0800
From: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
To: Ben Dooks <ben.dooks@...ethink.co.uk>, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org
Cc: mingo@...hat.co, peterz@...radead.org, namhyung@...nel.org
Subject: Re: [PATCH] perf/core: make nr_addr_filters attribute static


On 1/9/2026 8:27 PM, Ben Dooks wrote:
> The 'dev_attr_nr_addr_filters' attribute is not exported
> outside of the kernel/events/core.c file so make it static
> to avoid the following sparse warning:
>
> kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?
>
> Fixes: 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index dad0d3d2e85f..b79f9be8f074 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
>  
>  	return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
>  }
> -DEVICE_ATTR_RO(nr_addr_filters);
> +static DEVICE_ATTR_RO(nr_addr_filters);
>  
>  static struct idr pmu_idr;
>  

Reviewed-by: Dapeng Mi <dapeng1.mi@...ux.intel.com>