linux-kernel - [RFC 1/3] ASoC: simple-card: Do not print "parse error" twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260112231855.193030-2-development@redaril.me>
Date: Tue, 13 Jan 2026 00:12:22 +0100
From: Fabio Forni <development@...aril.me>
To: 
Cc: Fabio Forni <development@...aril.me>,
	Mark Brown <broonie@...nel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [RFC 1/3] ASoC: simple-card: Do not print "parse error" twice

If an error occurred on line 747, we'd print "parse error" and then go
to the `err` label, where we print the same message.
Let's remove the duplicated print.

Signed-off-by: Fabio Forni <development@...aril.me>
---
 sound/soc/generic/simple-card.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 5af6d1b308f2..8d36cbbfca1d 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -745,10 +745,8 @@ static int simple_probe(struct platform_device *pdev)
 	if (np && of_device_is_available(np)) {
 
 		ret = simple_parse_of(priv, li);
-		if (ret < 0) {
-			dev_err_probe(dev, ret, "parse error\n");
+		if (ret < 0)
 			goto err;
-		}
 
 	} else {
 		struct simple_util_info *cinfo;
-- 
2.52.0