lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e9f5eb88-e35e-48b2-9257-62e7073bdfa1@amd.com>
Date: Mon, 12 Jan 2026 11:41:58 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Zhan Xusheng <zhanxusheng1024@...il.com>, <peterz@...radead.org>
CC: <mingo@...hat.com>, <juri.lelli@...hat.com>, <vincent.guittot@...aro.org>,
	<dietmar.eggemann@....com>, <rostedt@...dmis.org>, <bsegall@...gle.com>,
	<mgorman@...e.de>, <vschneid@...hat.com>, <linux-sched@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Zhan Xusheng <zhanxusheng@...omi.com>
Subject: Re: [PATCH RESEND] sched/rt: remove empty sched_rt_do_global() helper

Hello Zhan,

On 1/12/2026 9:32 AM, Zhan Xusheng wrote:
> sched_rt_do_global() is an empty helper that has no effect on
> RT bandwidth sysctl handling.

Perhaps you can add small comment indicating its prior function:

sched_rt_do_global() was responsible for managing the RT throttling
parameters before the introduction of the fair server.

Since commit 5f6bd380c7bd ("sched/rt: Remove default bandwidth control")
sched_rt_do_global() turned obsolete but the empty helper was retained.

> 
> Remove the unused function and its call site to simplify the
> sysctl update path.
> 
> No functional change intended.
> 
> Signed-off-by: Zhan Xusheng <zhanxusheng@...omi.com>

Feel free to include:

Reviewed-and-tested-by: K Prateek Nayak <kprateek.nayak@....com>

-- 
Thanks and Regards,
Prateek


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ