linux-kernel - Re: [PATCH v3] nvme/host: fixup some typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <954593de-bfcc-467f-9279-bb6e87fb6df3@kernel.org>
Date: Mon, 12 Jan 2026 07:52:12 +0100
From: Damien Le Moal <dlemoal@...nel.org>
To: Wilfred Mallawa <wilfred.opensource@...il.com>,
 Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
 Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
 linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: Wilfred Mallawa <wilfred.mallawa@....com>
Subject: Re: [PATCH v3] nvme/host: fixup some typos

On 1/12/26 00:39, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@....com>
> 
> Fix up some minor typos in the nvme host driver and a comment
> style to conform to the standard kernel style.
> 
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@....com>
> Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
> ---
> V3:
>         - Fixup the comment to standarn kernel style
>         - Drop french style spacing removal.
> ---
>  drivers/nvme/host/tcp.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> index 69cb04406b47..92749f6d0f96 100644
> --- a/drivers/nvme/host/tcp.c
> +++ b/drivers/nvme/host/tcp.c
> @@ -25,7 +25,8 @@
>  
>  struct nvme_tcp_queue;
>  
> -/* Define the socket priority to use for connections were it is desirable
> +/*
> + * Define the socket priority to use for connections where it is desirable
>   * that the NIC consider performing optimized packet processing or filtering.
>   * A non-zero value being sufficient to indicate general consideration of any
>   * possible optimization.  Making it a module param allows for alternative
> @@ -926,7 +927,7 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb,
>  			req->curr_bio = req->curr_bio->bi_next;
>  
>  			/*
> -			 * If we don`t have any bios it means that controller
> +			 * If we don't have any bios it means that controller

Since you are correcting things, please do correct the grammar too:
...that the controller... :)

Personally, I prefer a more formal style, so I would also change "don't" into
"do not".

>  			 * sent more data than we requested, hence error
>  			 */
>  			if (!req->curr_bio) {


-- 
Damien Le Moal
Western Digital Research