linux-kernel - Re: [PATCH v4] wifi: iwlegacy: 3945-rs: remove redundant pointer check in il3945_rs_tx_status() and il3945_rs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260112070319.GA115711@wp.pl>
Date: Mon, 12 Jan 2026 08:03:19 +0100
From: Stanislaw Gruszka <stf_xl@...pl>
To: Tuo Li <islituo@...il.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] wifi: iwlegacy: 3945-rs: remove redundant pointer
 check in il3945_rs_tx_status() and il3945_rs_get_rate()

On Mon, Jan 12, 2026 at 01:11:18AM +0800, Tuo Li wrote:
> The variable il_sta passed into these two functions cannot be NULL, so
> remove the related null checks.
> 
> Signed-off-by: Tuo Li <islituo@...il.com>
Acked-by: Stanislaw Gruszka <stf_xl@...pl>

Thanks
Stanislaw
> ---
> v4:
> * Remove the redundant NULL check instead of using WARN_ON_ONCE(), and
>   update the subject accordingly.
>   Thanks to Stanislaw Gruszka for helpful advice.
> v3:
> * Replace plain NULL check with WARN_ON_ONCE() and update subject to better
>   reflect defensive nature of the check.
>   Thanks to Johannes Berg and Stanislaw Gruszka for helpful advice.
> v2:
> * Return early for uninitialized STA il data and align D_RATE messages with
>   il3945_rs_tx_status(). Add a wifi: prefix to the patch title.
>   Thanks to Stanislaw Gruszka for the helpful advice.
> ---
>  drivers/net/wireless/intel/iwlegacy/3945-rs.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/3945-rs.c b/drivers/net/wireless/intel/iwlegacy/3945-rs.c
> index 1826c37c090c..ecc6c8d2a4c5 100644
> --- a/drivers/net/wireless/intel/iwlegacy/3945-rs.c
> +++ b/drivers/net/wireless/intel/iwlegacy/3945-rs.c
> @@ -448,11 +448,6 @@ il3945_rs_tx_status(void *il_rate, struct ieee80211_supported_band *sband,
>  		return;
>  	}
>  
> -	if (!il_sta) {
> -		D_RATE("leave: No STA il data to update!\n");
> -		return;
> -	}
> -
>  	/* Treat uninitialized rate scaling data same as non-existing. */
>  	if (!rs_sta->il) {
>  		D_RATE("leave: STA il data uninitialized!\n");
> @@ -627,7 +622,7 @@ il3945_rs_get_rate(void *il_r, struct ieee80211_sta *sta, void *il_sta,
>  	D_RATE("enter\n");
>  
>  	/* Treat uninitialized rate scaling data same as non-existing. */
> -	if (rs_sta && !rs_sta->il) {
> +	if (!rs_sta->il) {
>  		D_RATE("Rate scaling information not initialized yet.\n");
>  		il_sta = NULL;
>  	}
> -- 
> 2.43.0
>