linux-kernel - Re: [PATCH 2/3] watchdog: atcwdt200: Add driver for Andes ATCWDT200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWSdNkHc-MAR5CRr@swlinux02>
Date: Mon, 12 Jan 2026 15:05:26 +0800
From: CL Wang <cl634@...estech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <wim@...ux-watchdog.org>, <linux@...ck-us.net>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-watchdog@...r.kernel.org>, <tim609@...estech.com>,
        <cl634@...estech.com>, <ben717@...estech.com>
Subject: Re: [PATCH 2/3] watchdog: atcwdt200: Add driver for Andes ATCWDT200

Hi Krzysztof,

Thanks for your review.

On 07/01/2026 15:50, Krzysztof Kozlowski wrote:

> Just use API for getting enabled clock.
Agreed. I will switch to using `devm_clk_get_enabled()` to simplify
the clock handling and error paths.

> No, read your binding. You said it is a list... list of phandles?
You are right. The property is intended to be a single uint32
configuration value. I will update the binding schema to clearly
define it as such and make it consistent with the driver.

> Just return.
Agreed. I will simplify the resume path and return directly on error.

> Drop, not needed.
Understood. I will drop the `"andestech,qilai-wdt"` compatible and keep
only the generic one.

> From where did you get this?
You're right, this is unnecessary. I will remove `.owner = THIS_MODULE`.

I will address all of the above in the next revision.

Best regards,
CL Wang