linux-kernel - Re: [PATCH v5] staging: fbtft: use dev_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeF+Sj=dxA4RZAvVddGSG3brUsy8kz7mvtst2YpqNm99w@mail.gmail.com>
Date: Mon, 12 Jan 2026 09:07:42 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Chintan Patel <chintanlike@...il.com>
Cc: linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev, 
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, tzimmermann@...e.de, andy@...nel.org, 
	deller@....de, gregkh@...uxfoundation.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v5] staging: fbtft: use dev_of_fbinfo() instead of info->dev

On Mon, Jan 12, 2026 at 3:07 AM Chintan Patel <chintanlike@...il.com> wrote:

> This fixes commit
> a06d03f9f238 ("staging: fbtft: Make FB_DEVICE dependency optional")

Convert to be as Fixes tag instead.

> from my previous v4 series:
> https://patchwork.kernel.org/project/dri-devel/cover/20260107044258.528624-1-chintanlike@gmail.com/

This is unneeded churn in the commit message, also this patch wrongly
marked as v5 that triggered Greg's bot response. You had to number it
as v1, but now please, address the above and below comments and make
it v6 with a Changelog added (explaining changes in v5 and in v6).

> All direct accesses to info->dev or fb_info->dev are replaced with
> dev_of_fbinfo() helper, improving readability and ensuring
> compilation succeeds when CONFIG_FB_DEVICE=n.

...

> @@ -364,8 +364,9 @@ static int fbtft_fb_setcolreg(unsigned int regno, unsigned int red,
>  {
>         unsigned int val;
>         int ret = 1;
> +       struct device *dev = dev_of_fbinfo(info);

Try to keep it in reversed xmas tree order.

...

>  static int fbtft_fb_blank(int blank, struct fb_info *info)
>  {
>         struct fbtft_par *par = info->par;
> +       struct device *dev = dev_of_fbinfo(info);
>         int ret = -EINVAL;

Ditto.

> -       dev_dbg(info->dev, "%s(blank=%d)\n",
> +       dev_dbg(dev, "%s(blank=%d)\n",
>                 __func__, blank);

Since you are changing it anyway, make it one line.

...

> @@ -739,6 +741,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
>         char text2[50] = "";
>         struct fbtft_par *par = fb_info->par;
>         struct spi_device *spi = par->spi;
> +       struct device *dev = dev_of_fbinfo(fb_info);

Reversed xmas tree order (as much as it's possible with this added line).

-- 
With Best Regards,
Andy Shevchenko