linux-kernel - Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb977dc3-54ea-4c58-be85-111fd7e1c371@kernel.org>
Date: Mon, 12 Jan 2026 08:31:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stafford Horne <shorne@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Linux OpenRISC <linux-openrisc@...r.kernel.org>,
 Linus Walleij <linusw@...nel.org>, Bartosz Golaszewski <brgl@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/6] dt-bindings: gpio-mmio: Add opencores GPIO

On 11/01/2026 17:46, Stafford Horne wrote:
> On Sun, Jan 11, 2026 at 11:18:42AM +0100, Krzysztof Kozlowski wrote:
>> On Fri, Jan 09, 2026 at 01:43:53PM +0000, Stafford Horne wrote:
>>> Add a device tree binding for the opencores GPIO controller.
>>>
>>> On FPGA Development boards with GPIOs the OpenRISC architecture uses the
>>> opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
>>>
>>> Link: https://opencores.org/projects/gpio
>>> Signed-off-by: Stafford Horne <shorne@...il.com>
>>> ---
>>> Since v2:
>>>  - Fixup patch to simply add opencores,gpio and add an example.
>>
>> Simplify? You completely changed the meaning of binding here - now
>> device is not compatible.
>>
>> I don't know which one is correct, but your changelog must explain why
>> now devices are not compatible but they were before.
> 
> Hello,
> 
> Did you miss the 1/6 patch in this series?  We add the compatible string to the

There is no 1/6!

> driver there before we add it here.

How does it matter? How can you add something to the driver before you
document the ABI? Did you read the submitting patches doc?


> 
> Sorry, I thought the series and the over letter would be enough to understand
> what I meant by the "Fixup" description here.

You still did not answer to my comments.



Best regards,
Krzysztof