linux-kernel - Re: [PATCH v11 05/12] vdpa: document set_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJaqyWf8Ad+SvGu9rucpC6Pop=W9c9GbUVMySmxbR5rcUnFQvg@mail.gmail.com>
Date: Mon, 12 Jan 2026 08:39:01 +0100
From: Eugenio Perez Martin <eperezma@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev, 
	Maxime Coquelin <mcoqueli@...hat.com>, Laurent Vivier <lvivier@...hat.com>, Cindy Lu <lulu@...hat.com>, 
	jasowang@...hat.com, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, 
	Stefano Garzarella <sgarzare@...hat.com>, Yongji Xie <xieyongji@...edance.com>
Subject: Re: [PATCH v11 05/12] vdpa: document set_group_asid thread safety

On Sun, Jan 11, 2026 at 12:48 AM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Fri, Jan 09, 2026 at 04:24:23PM +0100, Eugenio Pérez wrote:
> > Document that the function races with the check of DRIVER_OK.
> >
> > Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
> > ---
> > Requested at
> > https://lore.kernel.org/lkml/CACGkMEvXdV4ukZE6xhLL0sSN70G=AWVQgpRnH98Fr4btzMkK9g@mail.gmail.com/
> > ---
> >  include/linux/vdpa.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
> > index 4cf21d6e9cfd..cd1b1f1321b9 100644
> > --- a/include/linux/vdpa.h
> > +++ b/include/linux/vdpa.h
> > @@ -312,7 +312,9 @@ struct vdpa_map_file {
> >   *                           @idx: virtqueue index
> >   *                           Returns the affinity mask
> >   * @set_group_asid:          Set address space identifier for a
> > - *                           virtqueue group (optional)
> > + *                           virtqueue group (optional).  It's not thread
> > + *                           safe to call this function concurrently with
> > + *                           set_status.
>
> Let's be explicit about what to do.
> "Caller must prevent this from being executed concurrently with
> set_status"?
>

Sure, I prefer your version too. Rewording for the next version, thanks!

>
> >   *                           @vdev: vdpa device
> >   *                           @group: virtqueue group
> >   *                           @asid: address space id for this group
> > --
> > 2.52.0
>