linux-kernel - Re: [PATCH v11 06/12] vhost: forbid change vq groups ASID if DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJaqyWeDu6+KBFAg0jNSS=zZWSc2Q0qnd=9bB+NdxvMDLunCZw@mail.gmail.com>
Date: Mon, 12 Jan 2026 08:50:40 +0100
From: Eugenio Perez Martin <eperezma@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev, 
	Maxime Coquelin <mcoqueli@...hat.com>, Laurent Vivier <lvivier@...hat.com>, Cindy Lu <lulu@...hat.com>, 
	jasowang@...hat.com, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, 
	Stefano Garzarella <sgarzare@...hat.com>, Yongji Xie <xieyongji@...edance.com>
Subject: Re: [PATCH v11 06/12] vhost: forbid change vq groups ASID if
 DRIVER_OK is set

On Sun, Jan 11, 2026 at 12:49 AM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Fri, Jan 09, 2026 at 04:24:24PM +0100, Eugenio Pérez wrote:
> > Only vdpa_sim support it.  Forbid this behavious as there is no use for
>
> behaviour
>

Fixing in the next version, thanks!

> > it right now, we can always enable it in the future with a feature flag.
> >
> > Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
> > ---
> >  drivers/vhost/vdpa.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> > index 9d25b735b43d..3f0184d42075 100644
> > --- a/drivers/vhost/vdpa.c
> > +++ b/drivers/vhost/vdpa.c
> > @@ -682,6 +682,8 @@ static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd,
> >                       return -EFAULT;
> >               if (idx >= vdpa->ngroups || s.num >= vdpa->nas)
> >                       return -EINVAL;
> > +             if (ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK)
> > +                     return -EBUSY;
> >               if (!ops->set_group_asid)
> >                       return -EOPNOTSUPP;
> >               return ops->set_group_asid(vdpa, idx, s.num);
> > --
> > 2.52.0
>