linux-kernel - Re: [PATCH v1] pwm: dwc: Use size macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <whjyiyejzdss6mwo7s46kmtshiawwkvoeheg3qjomlfndqhqve@uoaw3eyejent>
Date: Mon, 12 Jan 2026 08:59:57 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Raag Jadav <raag.jadav@...el.com>
Cc: andriy.shevchenko@...ux.intel.com, heikki.krogerus@...ux.intel.com, 
	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: Use size macro

Hello,

On Mon, Jan 05, 2026 at 02:47:37PM +0530, Raag Jadav wrote:
> Use SZ_4K from size.h instead of hardcoding constant.
> 
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> ---
>  drivers/pwm/pwm-dwc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> index b6c16139ce4a..86b72db58741 100644
> --- a/drivers/pwm/pwm-dwc.c
> +++ b/drivers/pwm/pwm-dwc.c
> @@ -22,13 +22,14 @@
>  #include <linux/pci.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/pwm.h>
> +#include <linux/sizes.h>
>  
>  #include "pwm-dwc.h"
>  
>  /* Elkhart Lake */
>  static const struct dwc_pwm_info ehl_pwm_info = {
>  	.nr = 2,
> -	.size = 0x1000,
> +	.size = SZ_4K,
>  };

I don't feel strong if this is an improvement or not. I applied it now
with s,size.h,linux/sizes.h, in the commit log.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)