linux-kernel - Re: [PATCH v2 2/2] x86/virt/tdx: Print TDX module version during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da8d8997-e8b8-41e8-909b-44c49cae4a08@linux.intel.com>
Date: Mon, 12 Jan 2026 16:32:11 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: Vishal Verma <vishal.l.verma@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-coco@...ts.linux.dev,
 kvm@...r.kernel.org, x86@...nel.org, Chao Gao <chao.gao@...el.com>,
 Dan Williams <dan.j.williams@...el.com>, Kai Huang <kai.huang@...el.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, Kiryl Shutsemau <kas@...nel.org>,
 Rick Edgecombe <rick.p.edgecombe@...el.com>
Subject: Re: [PATCH v2 2/2] x86/virt/tdx: Print TDX module version during init



On 1/10/2026 3:14 AM, Vishal Verma wrote:
> It is useful to print the TDX module version in dmesg logs. This is
> currently the only way to determine the module version from the host. It
> also creates a record for any future problems being investigated. This
> was also requested in [1].
> 
> Include the version in the log messages during init, e.g.:
> 
>   virt/tdx: TDX module version: 1.5.24
>   virt/tdx: 1034220 KB allocated for PAMT
>   virt/tdx: module initialized
> 
> Print the version in get_tdx_sys_info(), right after the version
> metadata is read, which makes it available even if there are subsequent
> initialization failures.
> 
> Based on a patch by Kai Huang <kai.huang@...el.com> [2]

Reviewed-by: Binbin Wu <binbin.wu@...ux.intel.com>

One nit below.

> 
> Signed-off-by: Vishal Verma <vishal.l.verma@...el.com>
> Reviewed-by: Chao Gao <chao.gao@...el.com>
> Cc: Chao Gao <chao.gao@...el.com>
> Cc: Rick Edgecombe <rick.p.edgecombe@...el.com>
> Cc: Kai Huang <kai.huang@...el.com>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Link: https://lore.kernel.org/all/CAGtprH8eXwi-TcH2+-Fo5YdbEwGmgLBh9ggcDvd6N=bsKEJ_WQ@mail.gmail.com/ # [1]
> Link: https://lore.kernel.org/all/6b5553756f56a8e3222bfc36d0bdb3e5192137b7.1731318868.git.kai.huang@intel.com # [2]
> ---
>  arch/x86/virt/vmx/tdx/tdx_global_metadata.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
> index 0454124803f3..4c9917a9c2c3 100644
> --- a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
> +++ b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
> @@ -105,6 +105,12 @@ static int get_tdx_sys_info(struct tdx_sys_info *sysinfo)
>  	int ret = 0;
>  
>  	ret = ret ?: get_tdx_sys_info_version(&sysinfo->version);
> +
> +	pr_info("Module version: %u.%u.%02u\n",
> +		sysinfo->version.major_version,
> +		sysinfo->version.minor_version,
> +		sysinfo->version.update_version);
> +

Nit:

There is a mismatch b/t the change log and the code.

The printed message will be 
    virt/tdx: Module version: x.x.xx
instead of the format in the change log
    virt/tdx: TDX module version: x.x.xx


>  	ret = ret ?: get_tdx_sys_info_features(&sysinfo->features);
>  	ret = ret ?: get_tdx_sys_info_tdmr(&sysinfo->tdmr);
>  	ret = ret ?: get_tdx_sys_info_td_ctrl(&sysinfo->td_ctrl);
>