linux-kernel - Re: [PATCH] soundwire: bus: fix off-by-one when allocating slave IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWS1j7IdRLCJTj1h@stanley.mountain>
Date: Mon, 12 Jan 2026 11:49:19 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
	linux-sound@...r.kernel.org,
	Bard Liao <yung-chuan.liao@...ux.intel.com>,
	Charles Keepax <ckeepax@...nsource.cirrus.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
	Vinod Koul <vkoul@...nel.org>, kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, lkp@...el.com,
	Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] soundwire: bus: fix off-by-one when allocating slave IDs

On Mon, Jan 12, 2026 at 11:26:51AM +0300, Dan Carpenter wrote:
> On Sun, Jan 11, 2026 at 10:27:08AM +0100, Markus Elfring wrote:
> > …
> > > Using SDW_FW_MAX_DEVICES(16) therefore allows an ID of 16 to be
> > > allocated, but the IRQ domain created for the bus is sized for IDs
> > > 0-15.  If 16 is returned, irq_create_mapping() fails and the driver
> > > ends up with an invalid IRQ mapping.
> > …
> > 
> > See also once more:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n659
> > 
> 
> Markus, please only comment when it's a bug in the patch instead of
> wrong advice about commit messages.

Sorry, if that was unclear.  The link is a real link to the documentation
which says:

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.

The rules that we write down are simplified guidelines which are designed
to be easy explain.  75 is the upper bound where checkpatch will complain.
But I think line wrapping at 72 or 74 characters is more common.  Either
way it's fine.

regards,
dan carpenter