linux-kernel - Re: [PATCH v3] ACPI: bus: Use OF match data for PRP0001 matched devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWS6q3tBlppsWXXl@kekkonen.localdomain>
Date: Mon, 12 Jan 2026 11:11:07 +0200
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Kartik Rajput <kkartik@...dia.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>, lenb@...nel.org,
	thierry.reding@...il.com, jonathanh@...dia.com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ACPI: bus: Use OF match data for PRP0001 matched
 devices

Hi Kartik, Andy,

On Mon, Jan 12, 2026 at 10:55:57AM +0200, Andy Shevchenko wrote:
> > 	if (!__acpi_match_device(adev, acpi_ids, of_ids, &acpi_id, &of_id))
> > 		return NULL;
> > 
> > 	if (acpi_id)
> > 		return (const void *)acpi_id->driver_data;
> > 
> > 	if (of_id)
> > 		return of_id->data;
> > 
> > 	return NULL;
> > 
> > Then, we can also remove acpi_of_device_get_match_data()?
> 
> At brief look it's indeed seems to be a good optimisation as well.

Looks good to me, too!

-- 
Sakari Ailus