linux-kernel - Re: [PATCH v2 0/2] lib/crypto: x86/sha: Add PHE Extensions support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4c74973-93c6-4c89-bf1c-33ca8521d251@zhaoxin.com>
Date: Mon, 12 Jan 2026 17:12:40 +0800
From: AlanSong-oc <AlanSong-oc@...oxin.com>
To: Eric Biggers <ebiggers@...nel.org>
CC: <herbert@...dor.apana.org.au>, <Jason@...c4.com>, <ardb@...nel.org>,
	<linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<CobeChen@...oxin.com>, <TonyWWang-oc@...oxin.com>, <YunShen@...oxin.com>,
	<GeorgeXue@...oxin.com>, <LeoLiu-oc@...oxin.com>, <HansHu@...oxin.com>
Subject: Re: [PATCH v2 0/2] lib/crypto: x86/sha: Add PHE Extensions support

On 12/20/2025 2:33 AM, Eric Biggers wrote:
> 
> On Fri, Dec 19, 2025 at 04:03:04PM +0800, AlanSong-oc wrote:
>> For Zhaoxin processors, the XSHA1 instruction requires the total memory
>> allocated at %rdi register must be 32 bytes, while the XSHA1 and
>> XSHA256 instruction doesn't perform any operation when %ecx is zero.
>>
>> Due to these requirements, the current padlock-sha driver does not work
>> correctly with Zhaoxin processors. It cannot pass the self-tests and
>> therefore does not activate the driver on Zhaoxin processors. This issue
>> has been reported in Debian [1]. The self-tests fail with the
>> following messages [2]:
>>
>> alg: shash: sha1-padlock-nano test failed (wrong result) on test vector 0, cfg="init+update+final aligned buffer"
>> alg: self-tests for sha1 using sha1-padlock-nano failed (rc=-22)
>> ------------[ cut here ]------------
>>
>> alg: shash: sha256-padlock-nano test failed (wrong result) on test vector 0, cfg="init+update+final aligned buffer"
>> alg: self-tests for sha256 using sha256-padlock-nano failed (rc=-22)
>> ------------[ cut here ]------------
> 
> This cover letter is misleading, as those self-test failures will still
> exist regardless of this patch series.

Indeed, those self-test failures will still occur even with this patch
series. I will add a separate commit in this series to restrict probing
of the padlock-sha driver on Zhaoxin processors based on the CPU family,
and explain the reason for those failures in that commit.

>> To enable XSHA1 and XSHA256 instruction support on Zhaoxin processors,
>> this series adds PHE Extensions support to lib/crypto for SHA-1 and
>> SHA-256, following the suggestion in [3].
>>
>> v1 link is below:
>> https://lore.kernel.org/linux-crypto/20250611101750.6839-1-AlanSong-oc@zhaoxin.com/
> 
> Please run the sha1 and sha256 KUnit test suites
> (CRYPTO_LIB_SHA1_KUNIT_TEST and CRYPTO_LIB_SHA256_KUNIT_TEST) before and
> after this series, with the benchmark enabled (CRYPTO_LIB_BENCHMARK),
> and show the results.  For this series to be considered, the tests need
> to pass and there needs to be a significant performance improvement.

In the next revision of this patch, I will add the KUnit test suite
results as well as benchmark results for SHA1 and SHA256.

Please accept my apologies for the delayed response due to
administrative procedures. Thank you for your review and valuable
suggestions.

Best Regards
AlanSong-oc