linux-kernel - Re: [PATCH v3 1/6] dt-bindings: iio: frequency: add adf41513

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ck6vexpeak47kob7niupkdg3nbyvp4nab7rqmz6niq4frf64y@tjnph6hno32z>
Date: Mon, 12 Jan 2026 10:04:02 +0000
From: Rodrigo Alencar <455.rodrigo.alencar@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, 
	Rodrigo Alencar <rodrigo.alencar@...log.com>
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Andy Shevchenko <andy@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v3 1/6] dt-bindings: iio: frequency: add adf41513

On 26/01/09 09:13AM, Krzysztof Kozlowski wrote:
> On Thu, Jan 08, 2026 at 12:14:50PM +0000, Rodrigo Alencar wrote:
> > +examples:
> > +  - |
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pll@0 {
> > +            compatible = "adi,adf41513";
> > +            reg = <0>;
> > +            spi-max-frequency = <10000000>;
> > +            clocks = <&ref_clk>;
> > +            avdd1-supply = <&vdd_3v3>;
> > +            avdd2-supply = <&vdd_3v3>;
> > +            avdd3-supply = <&vdd_3v3>;
> > +            avdd4-supply = <&vdd_3v3>;
> > +            avdd5-supply = <&vdd_3v3>;
> > +            vp-supply = <&vdd_3v3>;
> > +
> > +            adi,power-up-frequency-mhz = <12000>;
> > +            adi,charge-pump-current-microamp = <2400>;
> > +            adi,phase-detector-polarity-positive-enable;
> > +        };
> > +    };
> 
> One example - more complete, so the next one - is enough. They do not
> differ.
>

Not sure I undestood this message:
- are those examples 'enough' as the second one is 'more complete'?
- do I need to change the second example to be 'more complete',
  because 'they do not differ'?
- do I need to create 'one example' 'more complete', apart from the existing ones?
 
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pll@0 {
> > +            compatible = "adi,adf41513";
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> 
> Best regards,
> Krzysztof
> 

kind regards,

Rodrigo Alencar